Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ruff rules #205

Merged
merged 12 commits into from
Jan 9, 2025
Merged

Update ruff rules #205

merged 12 commits into from
Jan 9, 2025

Conversation

AlecThomson
Copy link
Collaborator

Adds and enables the following ruff rulesets:

I've let stubs if there we want to enable more rules. The biggest one is the UP rule, which enables the new-style types.

@AlecThomson
Copy link
Collaborator Author

I've also added better spellchecking via typos and fixed broken tests

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

Attention: Patch coverage is 79.94350% with 71 lines in your changes missing coverage. Please review.

Project coverage is 60.72%. Comparing base (b880de4) to head (7ee354f).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
flint/prefect/common/imaging.py 25.00% 9 Missing ⚠️
flint/ms.py 68.18% 7 Missing ⚠️
flint/sky_model.py 62.50% 6 Missing ⚠️
flint/bandpass.py 44.44% 5 Missing ⚠️
flint/coadd/linmos.py 61.53% 5 Missing ⚠️
flint/flagging.py 44.44% 5 Missing ⚠️
flint/selfcal/casa.py 28.57% 5 Missing ⚠️
flint/calibrate/aocalibrate.py 80.95% 4 Missing ⚠️
flint/prefect/flows/continuum_pipeline.py 33.33% 4 Missing ⚠️
flint/prefect/flows/continuum_mask_pipeline.py 0.00% 3 Missing ⚠️
... and 13 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #205      +/-   ##
==========================================
+ Coverage   60.60%   60.72%   +0.11%     
==========================================
  Files          35       35              
  Lines        6209     6230      +21     
==========================================
+ Hits         3763     3783      +20     
- Misses       2446     2447       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AlecThomson AlecThomson merged commit 4ea2cf2 into main Jan 9, 2025
4 checks passed
@AlecThomson AlecThomson deleted the ruff branch January 9, 2025 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants